Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error responses better #156

Closed
wants to merge 1 commit into from
Closed

Make error responses better #156

wants to merge 1 commit into from

Conversation

codehackerr
Copy link
Contributor

@codehackerr codehackerr commented Oct 22, 2024 •
edited
Loading

No description provided.

@codehackerr
Make error responses better
cc39109 
Currently the decompressed response body is given as a byte array
Converting it to string for better readability
@codehackerr
Copy link
Contributor Author

codehackerr commented Oct 22, 2024 •
edited
Loading

This is a DRAFT PR for enhancing the understanding and decision making

Decompressed HTTP responses + error ( GenericSwaggerError) object is holding byte[]. This is cryptic to read.
Here I changed one instance to string for demo purpose. We can replace the old Swagger error object, V2 may not be required.

@codehackerr codehackerr marked this pull request as draft October 22, 2024 20:29
codehackerr
codehackerr commented Oct 31, 2024
View reviewed changes
sdk/client/generic_swagger_error.go
// Error returns non-empty string if there was an error.
func (e GenericSwaggerError) Error() string {
func (e GenericSwaggerErrorV2) Error() string {
Copy link
Contributor Author

@codehackerr codehackerr Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't need GenericSwaggerErrorV2 , just for demo. Change GenericSwaggerError if we decide in favor.

@conductor-sdk conductor-sdk deleted a comment from shaileshpadave Oct 31, 2024
jmigueprieto
jmigueprieto requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@jmigueprieto jmigueprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codehackerr can you please add a description of what we want to achieve with this PR?

Based on what I know about this, what we want to fix is that our Client/SDK is suppressing the HTTP status code. That causes issues while debugging. How is this addressing it?

@codehackerr
Copy link
Contributor Author

The changes in this PR are based on a wrong interpretation. Closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmigueprieto jmigueprieto jmigueprieto requested changes

@v1r3n v1r3n Awaiting requested review from v1r3n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codehackerr @jmigueprieto