Do not return errors for engines that do not support changes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the db in the Destination * Add tests for the Source * Add the acceptance test (#10) * Add the acceptance test * Wrap config errors * Remove the unnecessary link to the source from the method's description of the acceptance test
* Add the information about the Source * Add the example of the position * Add some updates * Update the info about the iterator * Add the information about the CDC
* Update logic of separated by comma fields, refactoring of tests * Remove unnecessary strings.Trim calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added the next logic:
If the engine does not support mutation - do not return errors in case of an update/delete operation.
Quick checks: