Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the logic of a record.Key formatting #20

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Conversation

voscob
Copy link
Contributor

@voscob voscob commented Nov 10, 2022

Description

I've changed the logic of a record.Key formatting.

The keyColumns is an optional field.
If the field is not empty the system uses it to format record.Key, if not - makes a request to the database and uses the
received list of primary keys of the specified table. If the table does not contain primary keys, the system uses the
value of the orderingColumn field as the keyColumns value.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@voscob voscob requested a review from hariso November 10, 2022 17:55
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
source/source.go Outdated Show resolved Hide resolved
@voscob voscob requested a review from hariso November 14, 2022 13:20
@voscob voscob merged commit da4abfe into main Nov 16, 2022
@voscob voscob deleted the update-format-key branch November 16, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants