Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update destination keyColumns logic, rename general config to config in errors #27

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Update destination keyColumns logic, rename general config to config in errors #27

merged 1 commit into from
Nov 30, 2022

Conversation

voscob
Copy link
Contributor

@voscob voscob commented Nov 30, 2022

Description

In this pull request, I've updated the logic to return inappropriate (those column names that are not in the payload's keys) keyColumns names.
Also, I've renamed general config to config in the error wrappers.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@voscob voscob requested review from maksenius and oykmnk November 30, 2022 15:12
@voscob voscob merged commit c45dfa6 into main Nov 30, 2022
@voscob voscob deleted the destination-keyColumns branch November 30, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksenius maksenius maksenius approved these changes

@oykmnk oykmnk Awaiting requested review from oykmnk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voscob @maksenius