Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit bandwidth + assert records in test #4

Merged
merged 5 commits into from
May 17, 2023
Merged

limit bandwidth + assert records in test #4

merged 5 commits into from
May 17, 2023

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented May 15, 2023 •
edited
Loading

Description

Fixes #2

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner May 15, 2023 15:23
@maha-hajja maha-hajja mentioned this pull request May 15, 2023
Closed
10 tasks
hariso
hariso reviewed May 16, 2023
View reviewed changes
destination.go Outdated Show resolved Hide resolved
hariso
hariso reviewed May 16, 2023
View reviewed changes
destination_test.go Outdated Show resolved Hide resolved
@maha-hajja maha-hajja requested a review from hariso May 16, 2023 19:10
hariso
hariso reviewed May 17, 2023
View reviewed changes
destination.go Outdated Show resolved Hide resolved
@maha-hajja maha-hajja merged commit b7d5b6b into main May 17, 2023
@maha-hajja maha-hajja deleted the maha/bwlimitt branch May 17, 2023 10:52
@maha-hajja maha-hajja mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use bwlimit
2 participants
@maha-hajja @hariso