Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename streamService #6

Merged
merged 2 commits into from
May 23, 2023
Merged

rename streamService #6

merged 2 commits into from
May 23, 2023

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented May 22, 2023 •
edited
Loading

Description

rename streamService to SourceService, related to conduitio-labs/conduit-connector-grpc-server#4 (comment)

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner May 22, 2023 17:33
@maha-hajja maha-hajja mentioned this pull request May 22, 2023
Merged
3 tasks
@lovromazgon lovromazgon enabled auto-merge (squash) May 23, 2023 10:58
@lovromazgon lovromazgon merged commit 0c86fac into main May 23, 2023
@lovromazgon lovromazgon deleted the maha/rename-proto-service branch May 23, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maha-hajja @lovromazgon