Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mTLS to gRPC server #8

Merged
merged 11 commits into from
Jun 26, 2023
Merged

add mTLS to gRPC server #8

merged 11 commits into from
Jun 26, 2023

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Jun 14, 2023 •
edited
Loading

Description

Use mTLS secure connection
added a script to generate example certs
++ adding tests

Fixes #2

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner June 14, 2023 12:45
@maha-hajja maha-hajja changed the title add mTLS secure connection add mTLS to gRPC server Jun 21, 2023
lovromazgon
lovromazgon reviewed Jun 22, 2023
View reviewed changes
Copy link
Contributor

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See conduitio-labs/conduit-connector-grpc-client#12 (review) 🙃

@maha-hajja maha-hajja requested a review from lovromazgon June 22, 2023 15:18
lovromazgon
lovromazgon approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
test/generate-certs.sh Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
@maha-hajja maha-hajja merged commit af9b2f2 into main Jun 26, 2023
@maha-hajja maha-hajja deleted the maha/mtls branch June 26, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use mTLS for gRPC connection
2 participants
@maha-hajja @lovromazgon