Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HTTP client #2

Closed
wants to merge 7 commits into from
Closed

feat: Add HTTP client #2

wants to merge 7 commits into from

Conversation

raulb
Copy link
Contributor

@raulb raulb commented May 10, 2023

Description

This pull-request adds basic configuration to connect to a specific HTTP server.

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb marked this pull request as ready for review May 11, 2023 11:58
@raulb raulb requested a review from a team as a code owner May 11, 2023 11:58
config.go Show resolved Hide resolved
config.go Show resolved Hide resolved
config.go Show resolved Hide resolved
source.go Show resolved Hide resolved
source.go Show resolved Hide resolved
@raulb
Copy link
Contributor Author

raulb commented Apr 1, 2024

@maha-hajja we could close this one in favor of #17, right?

@maha-hajja maha-hajja mentioned this pull request Apr 1, 2024
3 tasks
@maha-hajja
Copy link
Contributor

@raulb sure! I changed the base to main on the other PR

@maha-hajja maha-hajja closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants