Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node label prefix #194

Closed
kartikjoshi21 opened this issue Apr 5, 2023 · 3 comments · Fixed by #195
Closed

Update node label prefix #194

kartikjoshi21 opened this issue Apr 5, 2023 · 3 comments · Fixed by #195

Comments

@kartikjoshi21
Copy link
Contributor

For Kubernetes version greater than or equal to 1.16, node label keys in the 'kubernetes.io' or 'k8s.io' namespace must begin with an allowed prefix (kubelet.kubernetes.io, node.kubernetes.io).

Update labels to be inline with latest version.
kartikjoshi21 added a commit to kartikjoshi21/operator that referenced this issue Apr 5, 2023
@kartikjoshi21
install: Update node label prefix
d8b599c 
Update node label from node-role.kubernetes.io to node.kubernetes.io

Fixes: confidential-containers#194
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
@kartikjoshi21 kartikjoshi21 mentioned this issue Apr 5, 2023
Merged
kartikjoshi21 added a commit to kartikjoshi21/operator that referenced this issue Apr 10, 2023
@kartikjoshi21
install: Update node label prefix
b537a2f 
For Kubernetes version greater than or equal to 1.16, node label keys
in the 'kubernetes.io' or 'k8s.io' namespace must begin with an allowed
prefix (kubelet.kubernetes.io, node.kubernetes.io).
Update node label from node-role.kubernetes.io to node.kubernetes.io

Fixes: confidential-containers#194
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
@mythi
Copy link
Contributor

mythi commented Apr 11, 2023

dup of #130?

kartikjoshi21 added a commit to kartikjoshi21/operator that referenced this issue Jun 16, 2023
@kartikjoshi21
install: Update node label prefix
93323d7 
For Kubernetes version greater than or equal to 1.16, node label keys
in the 'kubernetes.io' or 'k8s.io' namespace must begin with an allowed
prefix (kubelet.kubernetes.io, node.kubernetes.io).
Update node label from node-role.kubernetes.io to node.kubernetes.io

Fixes: confidential-containers#194
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
kartikjoshi21 added a commit to kartikjoshi21/operator that referenced this issue Jul 10, 2023
@kartikjoshi21
install: Update node label prefix
56b4442 
For Kubernetes version greater than or equal to 1.16, node label keys
in the 'kubernetes.io' or 'k8s.io' namespace must begin with an allowed
prefix (kubelet.kubernetes.io, node.kubernetes.io).
Update node label from node-role.kubernetes.io to node.kubernetes.io

Fixes: confidential-containers#194
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
fidencio pushed a commit that referenced this issue Jul 10, 2023
@kartikjoshi21 @fidencio
install: Update node label prefix
abd7952 
For Kubernetes version greater than or equal to 1.16, node label keys
in the 'kubernetes.io' or 'k8s.io' namespace must begin with an allowed
prefix (kubelet.kubernetes.io, node.kubernetes.io).
Update node label from node-role.kubernetes.io to node.kubernetes.io

Fixes: #194
Signed-off-by: Kartik Joshi <kartikjoshi@microsoft.com>
@genjuro214
Copy link

@kartikjoshi21 Do we have an issue or plan to update the label in cloud-api-adaptor? Daily e2e tests jobs have failed due to this change: https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/5515993957

@bpradipt
Copy link
Member

@genjuro214 this is the equivalent on cloud-api-adaptor - confidential-containers/cloud-api-adaptor#784

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

install: Update node label prefix kartikjoshi21/operator
4 participants
@mythi @bpradipt @kartikjoshi21 @genjuro214