Refer readers to build an image with D-Bus #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fidencio
approved these changes
Jul 21, 2023
Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com>
mythi
reviewed
Jul 24, 2023
| Refer to the `.github/workflows/enclave-cc-cicd.yaml` file for guidance about building | ||
| a `kindest/node` image that includes D-Bus and starting the Kind cluster with the image. | ||
|
|
||
| Kind version `v0.16.0` runs with the following Linux distributions: |
There was a problem hiding this comment.
In CI we use what the Github runners provide pre-installed and kind is already at v0.20.0:
Suggested change
| Kind version `v0.16.0` runs with the following Linux distributions: | |
| Kind version `v0.20.0` runs with the following Linux distributions: |
| for development purposes. | ||
|
|
||
| Kind version `v0.16.0` have been successfully tested on the following Linux distros. | ||
| Refer to the `.github/workflows/enclave-cc-cicd.yaml` file for guidance about building | ||
| a `kindest/node` image that includes D-Bus and starting the Kind cluster with the image. |
There was a problem hiding this comment.
would we want to give more details why D-Bus is needed? (now that I think of it, and since this is a doc for developers, an option for developers could also be to have the custom containerd built in that node image directly)
|
@mikemckiernan FYI, this is becoming obsolete as we move to use host |
#242 is merged so I'd suggest this one gets closed. |
|
Let's close this one as we don't depend anymore on using a build image with D-Bus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading this information would have saved me some time. Maybe it can help someone else.