Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kata-payload: Make resources for s390x overridden by base #321

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Jan 16, 2024

Due to the fact that kustomize does not allow the 2nd level of resource patch, this commit is to make the resources overridden by base directly.

Fixes: #320

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

Due to the fact that kustomize does not allow the 2nd level of
resource patch, this commit is to make the resources overridden
by base directly.

Fixes: confidential-containers#320

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @BbolroC

@BbolroC
Copy link
Member Author

BbolroC commented Jan 16, 2024

/test

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fitzthum fitzthum merged commit e290f0f into confidential-containers:main Jan 16, 2024
10 checks passed
@BbolroC BbolroC deleted the fix-kustomize-s390x branch January 16, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kustomize does not allow 2nd level override
3 participants