-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Include custom build for DEVELOPMENT.md #322
doc: Include custom build for DEVELOPMENT.md #322
Conversation
The e2e test for s390x runs successfully (https://github.com/confidential-containers/operator/actions/runs/7564405180) |
@BbolroC - can you re-based this to pick up the latest CI changes please (though I know it's doc, so not likely to impact them). Thanks |
4d7af98
to
f92ebab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
docs/DEVELOPMENT.md
Outdated
popd | ||
``` | ||
|
||
Additionally, there are alternative patch layers such as `peer-pods` or `s390x` in addition to the `default` layer. You may switch the directory accordingly based on your requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @BbolroC !
Not sure if you really meant patch layers
or path layers
. In any case, kustomize uses the jargon "overlay" to mean those directories, i.e., those are "kustomize overlay directories".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info. I will update the doc. 😉
The DEVELOPMENT.md lacks a case where a user wants to build/test a custom operator/payload image. This is to supplement those instructions for the case. This also covers an update on the incorrect information for s390x e2e test. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
f92ebab
to
5824ff5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me, but I have not directly tested the Kind instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @BbolroC !
The DEVELOPMENT.md does not cover a case where a user wants to build/test a custom operator/payload image. This is to supplement the case. This also covers an update on the incorrect information for s390x e2e test.
This PR should be merged after an e2e test for s390x in #295 runs properly.
Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com