CI: bump go version to 1.21.7 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldoktor
approved these changes
Mar 26, 2024
BbolroC
force-pushed
the
bump-go-version
branch
from
1415fe9
to
0ee92bc
Compare
It is to update a go version to 1.21.7 which makes the CI go green again. Fixes: confidential-containers#356 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
BbolroC
force-pushed
the
bump-go-version
branch
from
0ee92bc
to
2ef793a
Compare
stevenhorsman
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Thanks for the investigation and fix. It feels like us doing:
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
rather than having a pinned version of our dependencies means things like this are inevitable, so maybe we can discuss a longer-term strategy on the CI calls cc @wainersm
Hi, Lukas. I think the upstream is aware of this at kubernetes-sigs/controller-tools#888. Hopefully, they will resolve it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check out the issue below for details.
It is to update a go version to 1.21.7 which makes the CI go green again.
Fixes: #356
Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com