-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Update payloads for v0.9.0-alpha1 #388
Release: Update payloads for v0.9.0-alpha1 #388
Conversation
c02cb78
to
3d8e7b6
Compare
We have an issue with the enclave-cc test. This looks somewhat similar to the issue we saw with the last release, which had to do with the yaml files in the test being out of sync. Enclave-cc has had very few changes since that was fixed. We fiddled with the sgx CI node some, but I think this test is not running there. Not sure what the cause is yet. cc @Xynnn007 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @portersrc!
I'd like to bother you, though, to keep this as a draft till we have the enclave-cc issue fixed. So it avoids us merging it before running that CI.
@@ -9,7 +9,7 @@ spec: | |||
node.kubernetes.io/worker: "" | |||
config: | |||
installType: bundle | |||
payloadImage: quay.io/confidential-containers/runtime-payload-ci:enclave-cc-HW-cc-kbc-latest | |||
payloadImage: quay.io/confidential-containers/runtime-payload-ci:enclave-cc-HW-cc-kbc-v0.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to change from runtime-payload-ci
to runtime-payload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh great catch; thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice catch, indeed!
@github-actions
enclave-cc e2e tests / operator enclave-cc e2e tests (pull_request) Successful in 5m
3d8e7b6
to
1543d00
Compare
Update the enclave-cc payloads to point to the v0.9.1 release of enclave-cc and update the pre-reqs bundle even though enclave-cc doesn't actually use nydus yet. Signed-off-by: Chris Porter <porter@ibm.com>
Update Kata payloads to 3.6.0 and bump the reqs deploy payload. Signed-off-by: Chris Porter <porter@ibm.com>
Signed-off-by: Chris Porter <porter@ibm.com>
1543d00
to
004361a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please, do NOT wait for the TDX machine for merging it. I took the machine down Today as I was trying to properly deal with some leftovers that were causing issues with re-runs, and now I'm in the middle of a whac-a-mole regarding Ubuntu 24.04 support for the ansible stuff. |
I am going to wait until tomorrow to tag the repo to make sure that we don't need something else for CAA. |
I think you are fine to go ahead this release, but we should update the checklist to have the peer pods stage before the operator if we are still planning to stick with the previously discussed plan? |
This updates the payloads for v0.9.0-alpha1