Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Remove centos8 configuration #390

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

ldoktor
Copy link
Contributor

@ldoktor ldoktor commented Jun 25, 2024

Centos8 is EOL and unavailable anymore. I tried centos9 but that one is incorrectly configured in Vagrant:

https://github.com/hashicorp/vagrant/issues/13272

and besides we don't really care at this point. Let's remove centos completely.

@ldoktor
Copy link
Contributor Author

ldoktor commented Jun 25, 2024

Note I left the centos vars and config there, only removed the vagrant configuration so it's easier to bring it back if we ever decide it's needed. I think best-effort approach would be better than complete removal, but let me know what you think.

Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ldoktor!

@fidencio
Copy link
Member

fidencio commented Aug 5, 2024

Could you please rebase atop of the current main?

@ldoktor
Copy link
Contributor Author

ldoktor commented Aug 5, 2024

Changes:

  • No changes, just rebased

@wainersm
Copy link
Member

Hi @ldoktor ! let's rebase it and try CI again ?

Centos8 is EOL and unavailable anymore. I tried centos9 but that one is
incorrectly configured in Vagrant:

    hashicorp/vagrant#13272

and besides we don't really care at this point. Let's remove centos
completely.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
@ldoktor
Copy link
Contributor Author

ldoktor commented Aug 14, 2024

Changes:

  • just rebased, no changes

Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ldoktor !

@wainersm wainersm merged commit 314868e into confidential-containers:main Aug 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants