-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Remove centos8 configuration #390
Conversation
Note I left the centos vars and config there, only removed the vagrant configuration so it's easier to bring it back if we ever decide it's needed. I think best-effort approach would be better than complete removal, but let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @ldoktor!
Could you please rebase atop of the current |
Changes:
|
Hi @ldoktor ! let's rebase it and try CI again ? |
Centos8 is EOL and unavailable anymore. I tried centos9 but that one is incorrectly configured in Vagrant: hashicorp/vagrant#13272 and besides we don't really care at this point. Let's remove centos completely. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ldoktor !
Centos8 is EOL and unavailable anymore. I tried centos9 but that one is incorrectly configured in Vagrant:
and besides we don't really care at this point. Let's remove centos completely.