Requested changes

configcat · Sep 1, 2023 · a9063d0 · a9063d0
1 parent cd4b022
commit a9063d0
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/src/ConfigCatClient/Evaluation/EvaluateContext.cs b/src/ConfigCatClient/Evaluation/EvaluateContext.cs
@@ -5,6 +5,23 @@ namespace ConfigCat.Client.Evaluation;
 
 internal struct EvaluateContext
 {
+    public readonly string Key;
+    public readonly Setting Setting;
+    public readonly SettingValue DefaultValue;
+    public readonly User? User;
+    public readonly IReadOnlyDictionary<string, Setting> Settings;
+
+    private IReadOnlyDictionary<string, string>? userAttributes;
+    public IReadOnlyDictionary<string, string>? UserAttributes => this.userAttributes ??= this.User?.GetAllAttributes();
+
+    private List<string>? visitedFlags;
+    public List<string> VisitedFlags => this.visitedFlags ??= new List<string>();
+
+    public bool IsMissingUserObjectLogged;
+    public bool IsMissingUserObjectAttributeLogged;
+
+    public IndentedTextBuilder? LogBuilder;
+
     public EvaluateContext(string key, Setting setting, SettingValue defaultValue, User? user, IReadOnlyDictionary<string, Setting> settings)
     {
         this.Key = key;
@@ -26,21 +43,4 @@ public EvaluateContext(string key, Setting setting, ref EvaluateContext dependen
         this.visitedFlags = dependentFlagContext.VisitedFlags; // crucial to use the property here to make sure the list is created!
         this.LogBuilder = dependentFlagContext.LogBuilder;
     }
-
-    public readonly string Key;
-    public readonly Setting Setting;
-    public readonly SettingValue DefaultValue;
-    public readonly User? User;
-    public readonly IReadOnlyDictionary<string, Setting> Settings;
-
-    private IReadOnlyDictionary<string, string>? userAttributes;
-    public IReadOnlyDictionary<string, string>? UserAttributes => this.userAttributes ??= this.User?.GetAllAttributes();
-
-    private List<string>? visitedFlags;
-    public List<string> VisitedFlags => this.visitedFlags ??= new List<string>();
-
-    public bool IsMissingUserObjectLogged;
-    public bool IsMissingUserObjectAttributeLogged;
-
-    public IndentedTextBuilder? LogBuilder;
 }
diff --git a/src/ConfigCatClient/Models/PercentageOption.cs b/src/ConfigCatClient/Models/PercentageOption.cs
@@ -17,7 +17,7 @@ public interface IPercentageOption : ISettingValueContainer
     /// <summary>
     /// A number between 0 and 100 that represents a randomly allocated fraction of the users.
     /// </summary>
-    int Percentage { get; }
+    byte Percentage { get; }
 }
 
 internal sealed class PercentageOption : SettingValueContainer, IPercentageOption
@@ -27,7 +27,7 @@ internal sealed class PercentageOption : SettingValueContainer, IPercentageOptio
 #else
     [JsonPropertyName("p")]
 #endif
-    public int Percentage { get; set; }
+    public byte Percentage { get; set; }
 
     public override string ToString()
     {