Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More config v6 tests #102

Merged
merged 25 commits into from
Mar 21, 2024
Merged

More config v6 tests #102

merged 25 commits into from
Mar 21, 2024

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented Jan 29, 2024

Describe the purpose of your pull request

Adds a few additional test cases for testing config v6 features.

Also, fixes come inconsistencies with other SDKs.

Breaking changes:

  • Change the name of some UserComparator members: Is(Not)OneOf -> TextIs(Not)OneOf, SensitiveIs(Not)OneOf -> SensitiveTextIs(Not)OneOf, (Not)ContainsAnyOf ->Text(Not)ContainsAnyOf

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 requested a review from a team as a code owner January 29, 2024 13:19
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: Patch coverage is 96.26168% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.64%. Comparing base (68e2306) to head (a3763ef).

Files Patch % Lines
src/RolloutEvaluator.ts 93.87% 3 Missing ⚠️
src/EvaluateLogBuilder.ts 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   92.68%   92.64%   -0.05%     
==========================================
  Files          21       21              
  Lines        2079     2093      +14     
  Branches      565      544      -21     
==========================================
+ Hits         1927     1939      +12     
- Misses        151      153       +2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adams85 adams85 mentioned this pull request Jan 29, 2024
30 tasks
@adams85 adams85 force-pushed the more-configv6-tests branch 2 times, most recently from 9c1eb14 to 2dcc8e1 Compare January 30, 2024 14:11
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adams85 adams85 merged commit 547bc42 into master Mar 21, 2024
18 checks passed
@adams85 adams85 deleted the more-configv6-tests branch March 21, 2024 10:52
This was referenced Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants