-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subtle memory leak issue #97
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 91.75% 91.65% -0.11%
==========================================
Files 18 18
Lines 1613 1629 +16
Branches 408 411 +3
==========================================
+ Hits 1480 1493 +13
- Misses 132 135 +3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
477342c
to
9f45459
Compare
9977005
to
45089a0
Compare
… issues with GC when awaiting IConfigCatClient.waitForReady
66f856b
to
1fe7fa5
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Describe the purpose of your pull request
A hook event handler which closes over the client instance should not prevent the client from being collected by the GC when user has no more references to the client.
Requirement checklist (only if applicable)