Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift Package Manager support to ConfigCat SDK for the Apple platforms #11

Merged

Conversation

barkoded
Copy link
Contributor

@barkoded barkoded commented Jan 5, 2021

This pull request adds Swift Package Manager support to the ConfigCat client SDK for the Apple platforms. As part of the changes the following have happened:

  • Source and test files have been moved to Sources and Tests.
  • Number of Xcode targets have been minimised to ConfigCat and ConfigCat Tests (with support for all 4 platforms).
  • Version number is a constant defined in ConfigFetcher.swift and ConfigCat.podspec.
  • Changed TravisCI to use Xcode 12.2

Updated the source_files property in the podspec to match the location of the source code.
Updated the Travis configuration to use the shared ConfigCat scheme
Changed the version to be a constant as infoDictionary?["CFBundleShortVersionString"] isn’t available when working with the Swift Package Manager as of Swift 5.3.  Additionally updated the deployment documentation.
Improve the tests by running them in parallel and random order.
Bumped the version to 7.2.0 to match the description in the README.md.
Updated the TravisCI macOS image to use Xcode 12.2. Updated all xcodebuild accordingly to support the change of Xcode.
Fixed cmdline compilation due to missing dependecy from test target to framework target.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 31 Code Smells

No Coverage information No Coverage information
4.3% 4.3% Duplication

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #11 (377a2d5) into master (ee30e43) will decrease coverage by 7.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   91.69%   84.65%   -7.04%     
==========================================
  Files          26       31       +5     
  Lines        1421     1688     +267     
==========================================
+ Hits         1303     1429     +126     
- Misses        118      259     +141     
Impacted Files Coverage Δ
Sources/ConfigCat/AsyncResult.swift 83.14% <ø> (ø)
Sources/ConfigCat/AutoPollingPolicy.swift 91.17% <ø> (ø)
Sources/ConfigCat/ConfigCache.swift 100.00% <ø> (ø)
Sources/ConfigCat/ConfigCatClient.swift 58.37% <ø> (ø)
Sources/ConfigCat/ConfigCatUser.swift 64.00% <ø> (ø)
Sources/ConfigCat/ConfigFetcher.swift 97.50% <ø> (ø)
Sources/ConfigCat/ConfigParser.swift 77.77% <ø> (ø)
Sources/ConfigCat/KeyValue.swift 100.00% <ø> (ø)
Sources/ConfigCat/LazyLoadingPolicy.swift 95.74% <ø> (ø)
Sources/ConfigCat/Log.swift 85.71% <ø> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b8475...377a2d5. Read the comment docs.

@z4kn4fein z4kn4fein merged commit e4233cd into configcat:master Jan 5, 2021
@barkoded barkoded deleted the feature/swift-package-manager-support branch January 14, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants