Change class name User to ConfigCatUser #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @z4kn4fein
I have proposing to renameing it to
ConfigCatUser
instead. I note that you have proposed to change to CCUser, but I think it might result in a higher chance of namespace conflict again.I am taking into consideration
My dependency on CometChatPro might also result in proposing for CCUser on their end.
I noticed that you have adopted a fuller namespace and the use of
ConfigCat
as prefixes for some of the classes, i.e.ConfigCatClientProtocol
,ConfigCatClient
.