Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change class name User to ConfigCatUser #8

Merged
merged 3 commits into from
Oct 30, 2020

Conversation

JohnKuan
Copy link

Hi, @z4kn4fein

I have proposing to renameing it to ConfigCatUser instead. I note that you have proposed to change to CCUser, but I think it might result in a higher chance of namespace conflict again.

I am taking into consideration

  1. My dependency on CometChatPro might also result in proposing for CCUser on their end.

  2. I noticed that you have adopted a fuller namespace and the use of ConfigCat as prefixes for some of the classes, i.e. ConfigCatClientProtocol, ConfigCatClient .

@z4kn4fein
Copy link
Member

Hey, thanks for the PR, we discussed and approved your change proposal, could you please resolve the remaining conflicts?

@z4kn4fein z4kn4fein self-requested a review October 29, 2020 14:38
John Kuan added 2 commits October 30, 2020 09:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JohnKuan
Copy link
Author

Hi @z4kn4fein,

Please have a look at my merge conflict resolution to see if it is okay on your end.

Thanks!

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files          25       25           
  Lines        1376     1376           
=======================================
  Hits         1260     1260           
  Misses        116      116           
Impacted Files Coverage Δ
Sources/ConfigCatUser.swift 88.88% <ø> (ø)
Sources/ConfigCatClient.swift 76.69% <100.00%> (ø)
Sources/ConfigParser.swift 81.08% <100.00%> (ø)
Sources/RolloutEvaluator.swift 94.78% <100.00%> (ø)
Tests/RolloutIntegrationTests.swift 86.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59538b6...dac427f. Read the comment docs.

@z4kn4fein z4kn4fein merged commit abc2682 into configcat:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants