Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmjs-types 0.9.0 doesn't compile #92

Closed
PFC-developer opened this issue Mar 6, 2024 · 3 comments
Closed

cosmjs-types 0.9.0 doesn't compile #92

PFC-developer opened this issue Mar 6, 2024 · 3 comments

Comments

@PFC-developer
Copy link

when I try to use it the following file stops vercel from building it.
removing the utf-8 character seems to make it happy locally.


Failed to compile.
16:28:22.092 |  
16:28:22.092 | ./node_modules/@cosmjs/encoding/build/utf8.d.ts:1:1
16:28:22.092 | Type error: File appears to be binary.
16:28:22.092 |  
16:28:22.093 | > 1 \| export declare function toUtf8(str: string): Uint8Array;
16:28:22.093 | \| ^
16:28:22.093 | 2 \| /**
16:28:22.093 | 3 \|  * Takes UTF-8 data and decodes it to a string.
16:28:22.093 | 4 \|  *
16:28:22.219 | Error: Command "yarn run build" exited with 1
16:28:22.843

<br class="Apple-interchange-newline">
@webmaster128
Copy link
Member

Hey hey!

This looks like a bug in the tool that is executed at the build step. The linter? It probably checks for � to differentiate text from binary files but � is a valid unicode character. But it should be simple enough to change the doc comment to work around it.

@PFC-developer
Copy link
Author

yeah..
I agree it would be better to fix the underlying issue.. i'm just not sure where that is.

webmaster128 added a commit to cosmos/cosmjs that referenced this issue Mar 8, 2024
webmaster128 added a commit to cosmos/cosmjs that referenced this issue Mar 8, 2024
@webmaster128
Copy link
Member

Done in cosmos/cosmjs#1570. This will be part of the next patch release of @cosmjs/encoding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants