Validator groups

[ethanfrey]

Closes #5

[ethanfrey]

Happy for a first review when you can. I need to implement the validator set calculation logic, but all the basics should be wired together

[maurolacy]

I noticed in passing that, according to RegisterValidatorKey comments, No two operators may have the same consensus_key. That is not currently being enforced in execute_register_validator_key AFAIK.

[ethanfrey]

I noticed in passing that, according to RegisterValidatorKey comments, No two operators may have the same consensus_key. That is not currently being enforced in execute_register_validator_key AFAIK.

Very good point, I will add that check - duplicates there could cause issues (attack vectors) in other code.

Also, when you can review the last 2 commits, please do so, I am sure you can find some issues there as well. Then I will do a push with all the suggested improvements. Very helpful review.

[maurolacy]

Still reviewing calculate_diff.

[maurolacy]

lgtm. Some tests are missing, but I agree we can add them in another iteration.