Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CosmJS to 0.31 and cosmjs-types to 0.8.0 #270

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

webmaster128
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

🦋 Changeset detected

Latest commit: 5a1bcf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@confio/relayer Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Wonder about compatibility with the protobuf message

@@ -705,7 +705,7 @@ export class IbcClient {
value: MsgUpdateClient.fromPartial({
signer: senderAddress,
clientId,
header: {
clientMessage: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works with newer versions of the SDK then?
It would be good to document compatibility

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field was renamed in cosmos/ibc-go#1871. But since it is the same field number in the protobuf serialization as before I assume nothing bad happens with the change 🤞

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only difference is amino signing, then? Which likely isn't relevant here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Amino JSON as well as other JSON exports if they exist. But I doubt this matters here.

@webmaster128 webmaster128 merged commit 9c2193b into main Aug 15, 2023
4 checks passed
@webmaster128 webmaster128 deleted the upgrade-cosmjs-0.31 branch August 15, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants