Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure CommitSig Timestamp is empty if BlockIdFlag is ABSENT -- DO_NOT_MERGE #277

Closed
wants to merge 3 commits into from

Conversation

clockworkgr
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: cebed07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@confio/relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clockworkgr clockworkgr changed the title fix: Set pre-1970 timestamps to 0 fix: Ensure CommitSig Timestamp is empty if BlockIdFlag is ABSENT Nov 29, 2023
@clockworkgr clockworkgr changed the title fix: Ensure CommitSig Timestamp is empty if BlockIdFlag is ABSENT fix: Ensure CommitSig Timestamp is empty if BlockIdFlag is ABSENT -- DO_NOT_MERGE Nov 30, 2023
@clockworkgr
Copy link
Collaborator Author

Best if we close this in favour of cosmos/cosmjs#1516 (assuming it works, which it should)

@clockworkgr
Copy link
Collaborator Author

Best if we close this in favour of cosmos/cosmjs#1516 (assuming it works, which it should)

Tested cosmos/cosmjs#1516 and it works. Probably a better solution

@clockworkgr
Copy link
Collaborator Author

Closing in favour of #278

@clockworkgr clockworkgr closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant