Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid to retrieve a bigger payload than required at userLogin() #49

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

phansys
Copy link
Member

@phansys phansys commented Jan 21, 2020

Since userGet() is only called to check if authentication is required, the resulting output is not required. Retrieving just the count instead of the full user list is more efficient.

@phansys phansys added enhancement minor Changes labeled with "minor" can be published on minor releases, respecting SemVer. labels Jan 21, 2020
@phansys phansys requested a review from domibarton January 21, 2020 19:02
phansys added a commit that referenced this pull request Jan 21, 2020
…gin()` (phansys)

This PR was merged into the master branch.

Discussion
----------

Since `userGet()` is only called to check if authentication is required, the resulting output is not required. Retrieving just the count instead of the full user list is more efficient.

Commits
-------

6f703e2 Avoid to retrieve a bigger payload than required at `userLogin()`
@phansys phansys merged commit 6f703e2 into confirm:master Jan 21, 2020
@phansys phansys deleted the user_login branch January 21, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement minor Changes labeled with "minor" can be published on minor releases, respecting SemVer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant