Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLIENTS-2885: Wheel generation python 3.11 #1467

Merged
merged 5 commits into from
Nov 22, 2022
Merged

CLIENTS-2885: Wheel generation python 3.11 #1467

merged 5 commits into from
Nov 22, 2022

Conversation

pranavrth
Copy link
Member

Changes to generate python 3.11 wheel.

@pranavrth pranavrth changed the title Wheel generation python 3.11 CLIENTS-2885: Wheel generation python 3.11 Nov 18, 2022
edenhill
edenhill suggested changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested for all platforms by pushing a tag (.e.g, v2.0.0wheeltest1)?
Things usually break when upgrading cibuild or delvewheel

.travis.yml
@@ -51,13 +51,6 @@ jobs:
env: BUILD_WHEELS=1
script: tools/wheels/build-wheels.sh ${LIBRDKAFKA_VERSION#v} wheelhouse

- name: "Wheels: MacOSX x64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

Copy link
Member Author

@pranavrth pranavrth Nov 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These wheels are generated with Semaphore as well. Travis requires credits for OS wheel generation.

CHANGELOG.md Outdated Show resolved Hide resolved
@pranavrth
Copy link
Member Author

I have pushed v1.8.99 in Test PyPi. I also ran test-wheels.py on the wheels.

@edenhill
Copy link
Contributor

Don't push tags that resemble real versions (vA.B.C) - people will end up finding them (you'd be surprised) - always use a suffix that makes it clear it is a test tag, e.g., v1.9.3tst1 or similar.

@pranavrth pranavrth force-pushed the wheel-generation-python-3.11 branch from 160754a to 0a0505f Compare November 21, 2022 16:33
@pranavrth
Copy link
Member Author

It wasn't allowing to push v1.9.3tst4 due to PEP-440. I will remember your point for next test release. Shall I delete v1.8.99?

@edenhill
Copy link
Contributor

Seems like PEP-440 proposes using devN suffix.

Yes, delete that tag.

@pranavrth
Copy link
Member Author

Deleted.

1 Test is failing with the latest changes in librdkafka.

@pranavrth pranavrth requested a review from edenhill November 21, 2022 17:16
@edenhill
Copy link
Contributor

The transaction APIs will now return ERR__CONFLICT if there is an another ongoing or started API call.

We still return ERR__STATE if an API call is not valid in the current state, but the conflict check is done first, thus the change of error returns.
I recommend updating the test in python.

@edenhill
Copy link
Contributor

I don't see a tag build on travis, did you push a tag?

@pranavrth
Copy link
Member Author

I added v1.9.3tst5 tag to an older commit. Build for this is - https://app.travis-ci.com/github/confluentinc/confluent-kafka-python/builds/257637307

@pranavrth pranavrth marked this pull request as ready for review November 22, 2022 11:38
@pranavrth pranavrth requested a review from a team as a code owner November 22, 2022 11:38
edenhill
edenhill approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pranavrth pranavrth merged commit e98fa65 into master Nov 22, 2022
@pranavrth pranavrth deleted the wheel-generation-python-3.11 branch November 22, 2022 19:25
@sbv-csis sbv-csis mentioned this pull request Nov 23, 2022
Closed
7 tasks
mahajanadhitya pushed a commit that referenced this pull request Nov 23, 2022
@pranavrth @mahajanadhitya
Wheels generation python 3.11 (#1467)
69b70d4 
Script updates for creating wheel for python 3.11
Removed mac OS wheels generation from travis
Fixed failing test cases for transaction API
mahajanadhitya pushed a commit that referenced this pull request Feb 3, 2023
@pranavrth @mahajanadhitya
Wheels generation python 3.11 (#1467)
d2f252f 
Script updates for creating wheel for python 3.11
Removed mac OS wheels generation from travis
Fixed failing test cases for transaction API
mahajanadhitya pushed a commit that referenced this pull request Feb 3, 2023
@pranavrth @mahajanadhitya
Wheels generation python 3.11 (#1467)
577e391 
Script updates for creating wheel for python 3.11
Removed mac OS wheels generation from travis
Fixed failing test cases for transaction API
emasab pushed a commit that referenced this pull request Jun 19, 2023
@pranavrth @emasab
Wheels generation python 3.11 (#1467)
da43e1f 
Script updates for creating wheel for python 3.11
Removed mac OS wheels generation from travis
Fixed failing test cases for transaction API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edenhill edenhill edenhill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranavrth @edenhill