Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old java-faker with kotlin-faker #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serpro69
Copy link

@serpro69 serpro69 commented Jul 8, 2022

Replaced an old and buggy java-faker with kotlin-faker :)
Probably not much of a difference for a demo, but it's my first contribution here, so hopefully it's ok :)

Tests in event-driven-microservices-workshop module still fail, but they were failing even before this change, so I assume it's intentional, since this is a workshop code.

@serpro69 serpro69 requested a review from a team as a code owner July 8, 2022 06:48
@ybyzek
Copy link

ybyzek commented Jul 8, 2022

@serpro69 for my own education, can you please elaborate on why Kotlin Faker is a better replacement (beyond "old and buggy java-faker")?

@MichaelDrogalis from your work on https://github.com/MichaelDrogalis/voluble which uses Java Faker , do you have an opinion on this PR?

@serpro69
Copy link
Author

serpro69 commented Jul 8, 2022

Hi @ybyzek ,
kotlin faker offers more data providers, locales, and has extra "batteries" included as well - random instances of classes, unique values, etc. In addition to the above it's also faster.
You can also check some comparisons here if you're interested ;)

@rmoff
Copy link
Contributor

rmoff commented Aug 5, 2022

ping @MichaelDrogalis @ybyzek for input here plz

@rmoff
Copy link
Contributor

rmoff commented Sep 12, 2022

@MichaelDrogalis any thoughts on this? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants