Reset to initial connection state on connection update #257
+92
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Analysis Details0 Issues
Coverage and Duplications
Project ID: ide-sidecar |
Cerchie
reviewed
Dec 24, 2024
| @@ -107,6 +107,8 @@ default String sidecarUri(String endpointPath) { | |||
|
|
|||
| Connection createConnection(ConnectionSpec spec); | |||
There was a problem hiding this comment.
would we ever not want to reset on connection update?
There was a problem hiding this comment.
Maybe updating name or id perhaps shouldn't reset the connection status, but we don't want to introduce complex conditionals ("did id change? do this else that") and instead just reset if any part of the ConnectionSpec changes. Either way, the scheduled refresh of the connection status will keep us eventually up-to-date.
Cerchie
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Resolves #256
Any additional details or context that should be provided?
Pull request checklist
Please check if your PR fulfills the following (if applicable):