GH-144: Isolate error classification logic into single, testable class #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2021
gharris1727
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #144
A new
BigQueryErrorResponsesclass is added that isolates the logic for classifying error responses from BigQuery. Classes that used to perform their own error classification are updated to leverage this new class instead. An integration test suite is added for this new class that covers some but not all types of errors; some, such as backend errors and rate limit errors, are difficult or even impossible to test reliably.The 2.0.x branch is targeted in order to leverage the new integration testing infrastructure introduced there. This can be backported to 1.6.x if there is significant demand and someone willing to file the PR.