Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR fixes #4229

Merged
merged 3 commits into from
Mar 22, 2023
Merged

PR fixes #4229

merged 3 commits into from
Mar 22, 2023

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Mar 21, 2023

  • purge TAILQ
  • remove memory leaks
  • fix type warnings

pranavrth
pranavrth approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some non blocking minor comments. Let's discuss them offline. Meanwhile I am approving the PR.

src/rdkafka_queue.c Show resolved Hide resolved
tests/0137-barrier_batch_consume.c
@@ -87,6 +87,8 @@ static int consumer_batch_queue(void *arg) {
rd_kafka_message_destroy(rkmessage[i]);
}

rd_free(rkmessage);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is taken from TEST 0122 as it is. We should add this in that test as well.

@pranavrth pranavrth merged commit 2da4713 into dev_fix_batch_consumer_app_store_offset Mar 22, 2023
@pranavrth pranavrth deleted the dev_fix_batch_consumer_app_store_offset_pr1 branch March 22, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavrth pranavrth pranavrth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emasab @pranavrth