Gracefully drop Bitset encoding attempt if offset different too large #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astubbs
force-pushed
the
bug/drop-bitset
branch
2 times, most recently
from
d0993f1 to
5e0436b
Compare
astubbs
force-pushed
the
bug/drop-bitset
branch
2 times, most recently
from
c21a278 to
8841933
Compare
…short range) RunLength encoding will still be used. See confluentinc#37 Support BitSet encoding lengths longer than Short.MAX_VALUE confluentinc#37 A test did try to cover this, but the offset difference wasn't large enough.
…ode drop if too big Test now exercises the metadata stripping flow. Capture issue with run length encoding - short cast.
astubbs
force-pushed
the
bug/drop-bitset
branch
from
8841933 to
64d2be2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
Will be improved with #37