prepend_services argument for java_export #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests, remove un-needed lines add comments
add tests, remove un-needed lines add comments
nlou9
approved these changes
May 2, 2024
airlock-confluentinc bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
* add codeowners (#1) * Add exclusion info to pom.xml (#2) * Make java_export capable of writing exclusions to the POM file it generates. * Reformatted _exclusion_spec_list_to_json_test_impl --------- Co-authored-by: Patrick Prémont <ppremont@confluent.io> * Add an `implementation_deps` argument to pom generation (#3) * add bazel equivalent of gradle's 'implementation' scope * update get_implementation_coordinates * Update private/rules/maven_utils.bzl * Update private/rules/pom_file.bzl * Add an exception for COPYRIGHT and NOTICE files in the same way LICENSE is already supported * prepend_services argument for java_export (#9) * initial 'prepend services' implementation add tests, remove un-needed lines add comments * initial 'prepend services' implementation add tests, remove un-needed lines add comments * remove System.out.println from MergeJars * match indentation a bit better * match indentation a bit better in MergeJars * trigger ci * Skip non-class files in the exclusions processing (#10) * reimplement license retention on service provider files (#11) * initial 'prepend services' implementation add tests, remove un-needed lines add comments * remove System.out.println from MergeJars * match indentation a bit better * match indentation a bit better in MergeJars * trigger ci * concatenate service files instead of prepending license with extra property * remove unnecessary test * remove 'prepend-services' feature * Remove hardcoded javadocopts * Add support for resources in javadoc jars. Add support for make variable substitution in javadoc arguments. (#14) * Add support for resources in javadoc jars. Add support for make variable substitution in javadoc arguments. * remove unused deps * Add .strip() to assert to account for some difference in windows/mac * DP-14758 - add classifier to generated pom (#17) * add classifier to generated pom * fix typo * Fix pom generation for classifier artifacts * fix bad cherry-pick * support bom generation * add tests * add line missing from patch file * fix incorrect merge conflicts * fix incorrect merge conflicts --------- Co-authored-by: Lan Yao <111819456+lyao-77@users.noreply.github.com> Co-authored-by: Patrick Prémont <ppremont@confluent.io>
nlou9
added a commit
that referenced
this pull request
Oct 3, 2024
Set publish_maven_metadata default to True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have opened a PR for this upstream. All the detail is there: bazel-contrib#1123
I want to merge this to our fork sooner to unblock other work.