Merge branch '7.4.x' into 7.5.x by rayokota

confluentinc · Jun 14, 2024 · 3b280c4 · 3b280c4
2 parents b26c210 + 0b6699d
commit 3b280c4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/...buf-provider/src/main/java/io/confluent/kafka/schemaregistry/protobuf/ProtobufSchema.java b/...buf-provider/src/main/java/io/confluent/kafka/schemaregistry/protobuf/ProtobufSchema.java
@@ -1777,7 +1777,12 @@ public static Map<String, String> findParams(Optional<OptionElement> meta) {
     if (result == null) {
       return null;
     } else if (result instanceof Map) {
-      return (Map<String, String>) result;
+      Map<String, String> params = new LinkedHashMap<>();
+      Map<String, String> keyValue = (Map<String, String>) result;
+      String key = keyValue.get(KEY_FIELD);
+      String value = keyValue.get(VALUE_FIELD);
+      params.put(key, value);
+      return params;
     } else if (result instanceof List) {
       List<Map<String, String>> keyValues = (List<Map<String, String>>) result;
       Map<String, String> params = new LinkedHashMap<>();

diff --git a/...provider/src/test/java/io/confluent/kafka/schemaregistry/protobuf/ProtobufSchemaTest.java b/...provider/src/test/java/io/confluent/kafka/schemaregistry/protobuf/ProtobufSchemaTest.java
@@ -38,7 +38,8 @@
 import io.confluent.kafka.schemaregistry.protobuf.ProtobufSchemaUtils.FormatContext;
 import io.confluent.kafka.schemaregistry.protobuf.dynamic.DynamicSchema;
 import io.confluent.kafka.schemaregistry.protobuf.dynamic.MessageDefinition;
-
+import io.confluent.protobuf.MetaProto;
+import io.confluent.protobuf.MetaProto.Meta;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.HashMap;
@@ -1665,6 +1666,10 @@ public void testParams() {
         + " }];\n"
         + "}";
     ProtobufSchema schema = new ProtobufSchema(schemaString);
+    FieldDescriptor fd = schema.toDescriptor().findFieldByName("MIT_ACTUAL_PRICE");
+    Meta meta = fd.getOptions().getExtension(MetaProto.fieldMeta);
+    assertEquals("2", meta.getParamsOrThrow("scale"));
+
     // Ensure we can process params when creating a dynamic schema
     assertNotNull(schema.toDynamicSchema());
   }