Turn example main program into rust test #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this test is good enough to make sure everything builds and runs on github actions, which is good enough for now! |
ChrisJefferson
approved these changes
Nov 6, 2023
ChrisJefferson
approved these changes
Nov 6, 2023
Merged
|
if you merge main into this pr @Kieranoski702 we should be able to see whether the code coverage CI is fixed or not. thanks! |
|
I just did this, beware @Kieranoski702 before you push to the main branch of your fork (i.e. pull first). Also working on the main branch is not the best idea (unless when you are testing CI setup I suppose). Make a named branch on your fork instead. |
|
Look at this beauty: https://github.com/conjure-cp/conjure-oxide/actions/runs/6776413999 |
niklasdewally
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #34, I have turned the example program main into a test called
chuffed_basic_run.rs.I have decided to keep the
main.rsfile for now as I believe it will be useful for further development. The test simply checks that running the ffi bindings/wrappers does not cause a crash. In order to show the test case has passed I have used anassert!(true)at the end of the test function as without any kind of assert the test doesn't seem to run. Is there a better way of doing this? Happy to get suggestions on this as well as the test as a whole