fix: Biplate<Vec<Expr>> for Expr #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasdewally
force-pushed
the
fix/issue-16
branch
2 times, most recently
from
50e32ad to
3ecf0b7
Compare
Fixes bug where `Biplate<Vec<Expr>> for Expr` returns [] instead of the expected vector. This was due to `derive_iter` not handling the `Biplate<Iter<T>> for Iter<T>` case correctly. We already handled the special case of `Biplate<T> for Iter<T>`, but not the identity/ same type case (`Biplate<T> for T`) found in all other Biplates. This was causing `Biplate<Iter<Expr>> for Iter<Expr>` to return its `Iter<Expr>` children (using the `Biplate<T> for Iter<T>` case) instead of returning itself as expected. Fixes: #16
niklasdewally
force-pushed
the
fix/issue-16
branch
from
3ecf0b7 to
83a39e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where
Biplate<Vec<Expr>> for Exprreturns [] instead of the expected vector.This was due to
derive_iternot handling theBiplate<Iter<T>> for Iter<T>case correctly. We already handled the special case ofBiplate<T> for Iter<T>, but not the identity/ same type case (Biplate<T> for T) found in all other Biplates. This was causingBiplate<Iter<Expr>> for Iter<Expr>to return itsIter<Expr>children (using theBiplate<T> for Iter<T>case) instead of returning itself as expected.Fixes #16