Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Uniplate::holes and Uniplate::contexts #32

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

niklasdewally
Copy link
Collaborator

@niklasdewally niklasdewally commented Nov 29, 2024

Port holes and context functions from the original Haskell library.

@niklasdewally niklasdewally self-assigned this Nov 29, 2024
Port `holes` and `context` functions from the original Haskell library.
@niklasdewally
Copy link
Collaborator Author

@ozgurakgun would appreciate a sanity check for this.

Copy link
Contributor

@ozgurakgun ozgurakgun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! What's left before we have full zippers then? Now that we have holes and contexts, I think it's just the traversal functions, isn't it?

@niklasdewally
Copy link
Collaborator Author

Looks good! What's left before we have full zippers then? Now that we have holes and contexts, I think it's just the traversal functions, isn't it?

Yep!

@ozgurakgun
Copy link
Contributor

I only checked in my phone without running anything btw. One thing this made me think is whether we want iterators instead of vectors for some of the other functions too.

We never did performance profiling so hard to know.

@niklasdewally
Copy link
Collaborator Author

I only checked in my phone without running anything btw. One thing this made me think is whether we want iterators instead of vectors for some of the other functions too.

Thats the long-term goal. Still not sure whether to make the default operations return an iterator, or have a seperate iterator API though!

Also, the internal tree datastructure is not lazy yet...

@niklasdewally niklasdewally marked this pull request as ready for review November 29, 2024 17:12
@niklasdewally niklasdewally merged commit 74dde54 into main Nov 29, 2024
8 checks passed
@niklasdewally niklasdewally deleted the add-with_universe branch November 29, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants