Merge pull request #933 from gbirchmeier/i931

bugfix in FixToJson example
connamara · Jan 31, 2025 · 84602e8 · 84602e8
2 parents 71ba98e + 05bee4d
commit 84602e8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Examples/FixToJson/Program.cs b/Examples/FixToJson/Program.cs
@@ -23,7 +23,7 @@ static void FixToJson(
                     {
                         line = line.Trim();
                         msg.FromString(line, false, sessionDataDictionary, appDataDictionary, msgFactory);
-                        Console.WriteLine(comma + msg.ToJSON(convertEnumsToDescriptions: humanReadableValues));
+                        Console.WriteLine(comma + msg.ToJSON(appDataDictionary, convertEnumsToDescriptions: humanReadableValues));
                         comma = ",";
                     }
                 }

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -27,7 +27,7 @@ What's New
 * #887 - cleanup/nullable-ize FixValues, Session, DataDictionary, DataDictionaryProvider, Message, MessageCracker,
          SocketSettings, SslStreamFactory (gbirchmeier)
      * DataDictionary.CheckIsInGroup is now static
-     * Get rid of non-static DataDictionary.Validate functions
+     * Get rid of non-static DataDictionary.Validate functions; callers must use their static variants
 
 **Non-breaking changes**
 * #864 - when multiple threads race to init DefaultMessageFactory,
@@ -64,6 +64,7 @@ What's New
 * #925 - Make ToAdmin() support DoNotSend (zsojma)
 * #927 - Remove lock from ScreenLog as Console.WriteLine is thread safe and remove unnecessary Dispose call (Rob-Hague)
 * #926 - don't init FileLog writers until first use (Rob-Hague)
+* #931 - bugfix in FixToJson example program
 
 ### v1.12.0