Merge pull request #828 from gbirchmeier/i823-IOIQtyDDCorrection

get rid of IOIQty enums in FIX5 DDs, allow free string
connamara · Feb 1, 2024 · 95f0a07 · 95f0a07
2 parents 08e16be + 95a04c6
commit 95f0a07
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 30 deletions.
diff --git a/QuickFIXn/Fields/Fields.cs b/QuickFIXn/Fields/Fields.cs
@@ -7900,13 +7900,6 @@ public IOIQty()
         public IOIQty(string val)
             :base(Tags.IOIQty, val) {}
 
-
-        // Field Enumerations
-        public const string VAL_1000000000 = "0";
-        public const string SMALL = "S";
-        public const string MEDIUM = "M";
-        public const string LARGE = "L";
-        public const string UNDISCLOSED_QUANTITY = "U";
     }
 
 

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -57,6 +57,7 @@ What's New
 * #767 - avoid string conversions in FieldMap.Get{FieldType} where possible (Rob-Hague)
 * #785 - use correct SocketError "Shutdown" code when socket is deliberately shutdown (oclancy)
 * #711 - fix explicit 0.0.0.0 address binding (bohdanstefaniuk)
+* #823 - get rid of IOIQty enums in FIX5 DDs, allow free string (gbirchmeier)
 
 ### v1.11.2:
 * same as v1.11.1, but I fixed the readme in the pushed nuget packages

diff --git a/spec/fix/FIX50.xml b/spec/fix/FIX50.xml
@@ -4560,13 +4560,7 @@
    <value enum='M' description='MEDIUM' />
   </field>
   <field number='26' name='IOIRefID' type='STRING' />
-  <field number='27' name='IOIQty' type='STRING'>
-   <value enum='0' description='1000000000' />
-   <value enum='S' description='SMALL' />
-   <value enum='M' description='MEDIUM' />
-   <value enum='L' description='LARGE' />
-   <value enum='U' description='UNDISCLOSED_QUANTITY' />
-  </field>
+  <field number='27' name='IOIQty' type='STRING' />
   <field number='28' name='IOITransType' type='CHAR'>
    <value enum='C' description='CANCEL' />
    <value enum='N' description='NEW' />

diff --git a/spec/fix/FIX50SP1.xml b/spec/fix/FIX50SP1.xml
@@ -5295,13 +5295,7 @@
    <value enum='M' description='MEDIUM' />
   </field>
   <field number='26' name='IOIRefID' type='STRING' />
-  <field number='27' name='IOIQty' type='STRING'>
-   <value enum='0' description='1000000000' />
-   <value enum='S' description='SMALL' />
-   <value enum='M' description='MEDIUM' />
-   <value enum='L' description='LARGE' />
-   <value enum='U' description='UNDISCLOSED_QUANTITY' />
-  </field>
+  <field number='27' name='IOIQty' type='STRING' />
   <field number='28' name='IOITransType' type='CHAR'>
    <value enum='C' description='CANCEL' />
    <value enum='N' description='NEW' />
@@ -9626,4 +9620,4 @@
    <value enum='2' description='HEARTBEAT_MESSAGE_INDICATING_THAT_APPLICATION_IDENTIFIED_BY_REFAPPLID' />
   </field>
  </fields>
-</fix>
+</fix>
diff --git a/spec/fix/FIX50SP2.xml b/spec/fix/FIX50SP2.xml
@@ -5755,13 +5755,7 @@
    <value enum='M' description='MEDIUM' />
   </field>
   <field number='26' name='IOIRefID' type='STRING' />
-  <field number='27' name='IOIQty' type='STRING'>
-   <value enum='0' description='1000000000' />
-   <value enum='S' description='SMALL' />
-   <value enum='M' description='MEDIUM' />
-   <value enum='L' description='LARGE' />
-   <value enum='U' description='UNDISCLOSED_QUANTITY' />
-  </field>
+  <field number='27' name='IOIQty' type='STRING' />
   <field number='28' name='IOITransType' type='CHAR'>
    <value enum='C' description='CANCEL' />
    <value enum='N' description='NEW' />
@@ -10538,4 +10532,4 @@
   <field number='1620' name='RiskEncodedSecurityDescLen' type='LENGTH' />
   <field number='1621' name='RiskEncodedSecurityDesc' type='DATA' />
  </fields>
-</fix>
+</fix>