Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpServer Issue with SessionID #786

Closed
blindvit opened this issue Jul 20, 2023 · 2 comments · Fixed by #829
Closed

HttpServer Issue with SessionID #786

blindvit opened this issue Jul 20, 2023 · 2 comments · Fixed by #829

Comments

@blindvit
Copy link

I found one case when session cgf file has SenderSubID but the session listed in admin interface does not include it. This results into "Session not found" exception when user clicks the session details link. This exception is crashing the main process.

  • Add ability to attach SenderSubID to the session details link
  • For not found sessionId just render "Session not found message" to the html output (
    if (sessionDetails == null) throw new Exception("Session not found");
    )
The service threw an unhandled exception, System.Exception: Session not found
   at Acceptor.HttpServer.SessionDetails(HttpListenerRequest request)
   at Acceptor.HttpServer.ConnectionThreadStart()
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()
@gbirchmeier
Copy link
Member

Yep, I see what's up. The HttpServer constructs SessionID strings in a pretty naive way. I bet I can do that better.

@gbirchmeier
Copy link
Member

I started rewriting the whole HttpServer. Hopefully done tomorrow.

gbirchmeier added a commit to gbirchmeier/quickfixn that referenced this issue Feb 3, 2024
 connamara#786

* doesn't crash the QF application on errors
* now has sane HTML
* same uninspired design
gbirchmeier added a commit to gbirchmeier/quickfixn that referenced this issue Feb 3, 2024
 connamara#786

* doesn't crash the QF application on errors
* now has sane HTML
* same uninspired design
gbirchmeier added a commit to gbirchmeier/quickfixn that referenced this issue Feb 3, 2024
 connamara#786

* doesn't crash the QF application on errors
* now has sane HTML
* same uninspired design
gbirchmeier added a commit to gbirchmeier/quickfixn that referenced this issue Feb 5, 2024
 connamara#786

* doesn't crash the QF application on errors
* now has sane HTML
* same uninspired design
* reverted the access/name change to
  Session.Logon/Logout from connamara#826; that
  was a blunder (by me)
gbirchmeier added a commit to gbirchmeier/quickfixn that referenced this issue Feb 5, 2024
 connamara#786

* doesn't crash the QF application on errors
* now has sane HTML
* same no-frills design
* reverted the access/name change to
  Session.Logon/Logout from connamara#826; that change
  was a blunder (by me)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants