Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to allow disabling of enumeration validation. #646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rakker91
Copy link

@rakker91 rakker91 commented Aug 3, 2020

Sometimes providers change their schemas, adding new enum values not currently in our schema. When that happens, we don't want things to start failing.

By default, QuickFix will blow up if an enum value doesn't match and there's no way to turn this off.

This PR adds the ability to disable this validation, if desired. The default behavior is unchanged.

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gbirchmeier
Copy link
Member

I think this very thing was included in #543. I rejected that part, then the submitters "appealed" to me, then I said that I'd consider it, then... I forgot about it. (Sorry guys!)

I will take another look later this week.

@ubermanl
Copy link

Hi all, i just had this issue in production. The market doesn't provide the full spec for all the enum values. As i've seen and gathered from the Java version of quickfix, it's handled by an attribute called "allowOtherValues" included in the enum itself as i mentioned in the followeing ticket #658. I personally like this approach since its more granular and doesnt completely override checkups for all enums.

@VAllens
Copy link

VAllens commented Sep 15, 2021

Good idea, when to merge it?

@kirsan31
Copy link

kirsan31 commented Aug 14, 2023

+1 for this. It's a real problem when provider decide to add some new value to some new enums...
/cc @gbirchmeier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants