Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension method ReadGroups #741

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NoviProg
Copy link

@NoviProg NoviProg commented Sep 1, 2022

This method make it easy to work groups. By use enumerator

like this:

var nos = new QuickFix.FIX42.NewOrderSingle();
// ...
foreach (var item in nos.ReadGroups<QuickFix.FIX42.NewOrderSingle.NoTradingSessionsGroup>(Tags.NoTradingSessions))
{
    // ...do stuff with noSidesGrp...
 }

This method make it easy to work groups. By use enumerator
@CLAassistant
Copy link

CLAassistant commented Sep 1, 2022

CLA assistant check
All committers have signed the CLA.

@gbirchmeier
Copy link
Member

This is actually really cool, and I'm sorry I overlooked this when you first submitted it.

I might see if I can improve it a little bit tomorrow.

It would be really cool if we could make it not need the explicit counter-tag requirement, but there is currently no way in the code to get the tag from a group type. But I think I might be able to extend the code generator to give us something that could make that work... I'm going to keep thinking about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants