#770 Fix unobserved SocketException

[nmandzyk]

#770 Perform socket read operations according to Task-based asynchronous pattern (TAP) instead of Asynchronous Programming Model (APM)

• fix unobserved SocketException

[CLAassistant]

All committers have signed the CLA.

[Rob-Hague]

So the unobserved SocketExceptions were coming from closing the stream when disconnecting, and now we are cancelling the read with the CancellationTokenSource, and the ContinueWith is there to swallow the resulting OperationCanceledException on the Task. Is that right? Perhaps it is worth expanding the comment?

Suggested change

	// just wait when read task will be cancelled
	// The ContinueWith observes (and swallows) the resulting
	// OperationCanceledException on the task.
	// This avoids unobserved exceptions appearing elsewhere
	// (which we ultimately don't care about during disconnect)

[nmandzyk]

Hey @Rob-Hague . I am sorry for the delayed response. Not exactly. The unobserved exception was triggered when we call .BeginRead(...) and the other side just closed the connection. I reimplemented the socket reading based on Begin/End async approach to the task-based approach that will raise the exception on task awaits.
About the ContinueWith you are absolutely right.

[gbirchmeier]

This looks promising, as do a few other recent PRs by you and others.

I'm working to put out a new release right now. It will not include this, but I'm going to see if I can improve our process internally so we can start moving on a lot of these PRs for the next release after this (and have these releases come out on a more frequent bases).