Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SocketReader::ReadSome SocketError when socket closed #785

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Update SocketReader::ReadSome SocketError when socket closed #785

merged 1 commit into from
Jan 24, 2024

Commits on Jan 24, 2024

  1. Update SocketReader::ReadSome SocketError when socket closed 

    Update SocketInitiatorThread::ReadSome SocketError when socket closed

If 0 bytes are read it means the socket has been shutdown not reset. Had this issue in a production system reporting "Connection reset by peer" (the error message for SocketError.SocketReset), but using wireshark no RST packet was seen.
However we did see the FIN and FIN,ACK packets which means the socket was being deliberately shutdown. Turned out the venue had a maintenance job that shutdown the network connections.

Tldr; Setting to SocketError.Shutdown is the correct message for this scenario.
    @oclancy @gbirchmeier
    oclancy authored and gbirchmeier committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    84e06a2 View commit details
    Browse the repository at this point in the history