Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Try/Catch logic to SocketInitiator.OnStart() #834

Closed
wants to merge 1 commit into from

Conversation

Falcz
Copy link
Contributor

@Falcz Falcz commented Feb 13, 2024

Context in #833

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2024

CLA assistant check
All committers have signed the CLA.

@gbirchmeier
Copy link
Member

This doesn't build. You can't call session.Log there because there is no session identified.

I'm going to hack in a session-independent logger (similar to the File.AppendAllText hack in SocketInitiatorThreadStart()), but plan to replace that with something not-hacky very soon (see work-in-progress #830).

@gbirchmeier
Copy link
Member

Can I get your name for the credit page? It's not in your git log name. You can email to my username at connamara.com if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants