Weekdays setting #845
Closed
Weekdays setting #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirchmeier
reviewed
May 22, 2024
| throw new InvalidOperationException("NonStopSession is set -- this should never be called."); | ||
| } | ||
|
|
||
| if (_weekdays.Contains(time.DayOfWeek)) |
There was a problem hiding this comment.
This logic is faulty. If midnight falls within the session (e.g. it goes from 8am-2am), then it will erroneously return false between midnight-2am.
I'm fixing it in a new branch and will submit a new PR.
|
Thanks for your contribution, but I cannot accept this because: I've cherry-picked the middle commit into a new branch and will submit a new PR. |
gbirchmeier
pushed a commit
to gbirchmeier/quickfixn
that referenced
this pull request
May 23, 2024
issue connamara#844 (originally @MichalAssuri's commit 65f675d from PR connamara#845, but amended andexpanded by @gbirchmeier)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the issue: #844