Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc small fixes: update readme about .NET 8, delete unused SocketInitiator vars, fix possible-null warning #919

Merged
merged 3 commits into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions QuickFIXn/Transport/SocketInitiator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ namespace QuickFix.Transport
/// </summary>
public class SocketInitiator : AbstractInitiator
{
public const string SOCKET_CONNECT_HOST = "SocketConnectHost";
public const string SOCKET_CONNECT_PORT = "SocketConnectPort";
public const string RECONNECT_INTERVAL = "ReconnectInterval";

private volatile bool _shutdownRequested = false;
private DateTime _lastConnectTimeDt = DateTime.MinValue;
private int _reconnectInterval = 30;
Expand Down
4 changes: 4 additions & 0 deletions QuickFIXn/Transport/StreamFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ internal static Stream CreateClientStream(IPEndPoint endpoint, SocketSettings se

if (!settings.SocketIgnoreProxy)
{
if (settings.ServerCommonName is null) {
throw new ConfigError(
$"{SessionSettings.SOCKET_IGNORE_PROXY}=Y needs {SessionSettings.SSL_SERVERNAME} to be set");
}
// If system has configured a proxy for this config, use it.
socket = CreateTunnelThruProxy(endpoint.Address.ToString(), endpoint.Port, settings.ServerCommonName);
}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ development.
System Setup
------------

* This project uses .NET 6.
* This project uses .NET 8 starting with version 1.13.

* All scripts are in Powershell, and should work on both Windows and Unix-based platforms.

Expand Down
Loading