Upgrade ubuntu to 22.04 second try #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit af085f3.
Install libssl1.1 so we support common tools build for older ubuntu versions Workaround issue with newer libssl and older node versions
|
Kudos, SonarCloud Quality Gate passed!
|
|
Is the crypto issue with nodejs also fixed in this PR? |
|
I think we need to bump node to 16.17 to fix the crypto issue: nodejs/node#42919 |
chribsen
reviewed
Sep 21, 2022
|
I just tested the example script on v16.16.0 and it works: root@b436cdf917fb:/# node test.js
ArrayBuffer {
[Uint8Contents]: <fe fe 48 6a c6 0b ef b4 ba ab 79 03 bf 59 e3 7a 04 ab 69 c6 9d cb 62 6c de fe bc b9 f0 04 28 1c 7c 1f 12 41 e7 47 fb 38 ce ed 87 97 f7 01 a1 4a ad 18 d6 57 f5 c1 5b f0 1b 4a 41 92 78 b9 fd 54 7a 26 a9 a6 7f d0 2d df e8 18 ed a6 13 a7 9d e1 c0 29 17 eb ec d0 fc 58 92 53 d5 55 66 3f 16 e9 f5 cb 04 fd ... 12245 more bytes>,
byteLength: 12345
}
done.
root@b436cdf917fb:/# node --version
v16.16.0I would prefer to do the node upgrade in a separate pull. |
It was another crypto issue you had, and it was because node 12.x was used in the image, node 12.x is out of support. I added the fix for it anyway to the image. |
chribsen
approved these changes
Sep 23, 2022
yes, will do |
delete-merged-branch
bot
deleted the
revert-70-cd/revert-latest-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Ubuntu 18.04 source setup to common image
Install libssl1.1 so we support common tools build for older ubuntu versions
Workaround issue with newer libssl and older node versions
Also tag images with node version and commit sha