Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Adjust the implementation of the python wrappers #130

Merged
merged 4 commits into from
Dec 7, 2021
Merged

FIX: Adjust the implementation of the python wrappers #130

merged 4 commits into from
Dec 7, 2021

Conversation

sebastientourbier
Copy link
Member

  • Review the generation of the command
  • Add a new parser argument "--config_dir" to specify and map/bind it inside the container

sebastientourbier
sebastientourbier commented Dec 7, 2021
View reviewed changes
Copy link
Member Author

@sebastientourbier sebastientourbier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ready to be merged and tested in release/v3.0.0 branch 👍

@sebastientourbier sebastientourbier merged commit ca97ecf into release/v3.0.0 Dec 7, 2021
@sebastientourbier sebastientourbier deleted the enh/release/v3.0.0/docker_wrapper branch December 7, 2021 11:32
@sebastientourbier sebastientourbier mentioned this pull request Dec 23, 2021
Merged
@sebastientourbier sebastientourbier added this to the v3.0.0 milestone Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@sebastientourbier