Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wish I had done this before v1.0 so I could have just removed it without it being a back-compat issue. Oh well 🤷
The only reason I added it to begin with is because I could have sworn I had seen this supported in grpc-web -- not the official one, but an early version of the improbable-eng one. It was used to make payloads human-readable in a browser network inspector (JSON wasn't an option because the protobuf-js runtime doesn't support JSON encoding).
But I can't actually find anything about this now in the improbable-eng/grpc-web repo (even in the history, in case it used to be there and then they removed it). @gtg471h was investigating using grpc-web at FullStory several years ago, and we had looked at some of this together for how to get our Go backends to work with it... or so I thought. Am I misremembering this? (Maybe we had played around with a fork of the project that would send text?)
Anyhow, if there's nothing that supports this out-of-the-box, I find it highly unlikely that anyone would intentionally extend their gRPC or Connect deployments to use this format, so let's ax it.