Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETIMEDOUT is reported as internal #682

Closed
akosyakov opened this issue Jun 21, 2023 · 4 comments
Closed

ETIMEDOUT is reported as internal #682

akosyakov opened this issue Jun 21, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@akosyakov
Copy link
Contributor

version: 0.10.0

ConnectError: [internal] read ETIMEDOUT
	at i.from (/out/extension.js:2:1820120)
	at t.connectErrorFromNodeReason (/out/extension.js:2:1804959)
	at Promise.reject (/out/extension.js:2:1809452)
	at ClientHttp2Stream.<anonymous> (/out/extension.js:2:1811449)
	at ClientHttp2Stream.emit (node:events:513:28)
	at emitErrorNT (node:<REDACTED: user-file-path>:157:8)
	at emitErrorCloseNT (node:<REDACTED: user-file-path>:122:3)
	at process.processTicksAndRejections (node:<REDACTED: user-file-path>:83:21)

grpc-node reports it as unavailable: https://github.com/grpc/grpc-node/blob/186718cb70af708c75584909b21169289d7363b2/packages/grpc-js/src/subchannel-call.ts#L243

@akosyakov akosyakov added the bug Something isn't working label Jun 21, 2023
@timostamm
Copy link
Member

From the Node.js documentation:

ETIMEDOUT (Operation timed out): A connect or send request failed because the connected party did not properly respond after a period of time.

Mapping to Unavailable seems reasonable. Do you know what the underlying issue was?

@akosyakov
Copy link
Contributor Author

akosyakov commented Jun 21, 2023

Unfortunately it is from our extension error telemetry. I can only assume that it is some user network issue, but we do get many of them so would be nice to separate from actual internal issues.

@akosyakov
Copy link
Contributor Author

Original stack frame here:

i.from at ../node_modules/@bufbuild/connect/dist/cjs/connect-error.js:73:19
from at ../node_modules/@bufbuild/connect-node/dist/cjs/node-error.js:54:38
reason at ../node_modules/@bufbuild/connect-node/dist/cjs/node-universal-client.js:305:110
reject at ../node_modules/@bufbuild/connect-node/dist/cjs/node-universal-client.js:194:21
ClientHttp2Stream.emit at null:null:null
emitErrorNT (node:<REDACTED: at null:null:null
emitErrorCloseNT (node:<REDACTED: at null:null:null
process.processTicksAndRejections (node:<REDACTED: at null:null:null

so it came from here: https://github.com/bufbuild/connect-es/blob/76b17edbbc4c0d4c98d1de8eb754192835458054/packages/connect-node/src/node-universal-client.ts#L328

@timostamm
Copy link
Member

Thanks for the stack trace and the PR, @akosyakov. Fixed by #686.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants